Module talk:CR

Please use the module indirectly via Template:CR. Using the module directly is more likely to break in the future.

Work to be done (Article editing)

• Replace uses of Template:Rules and Template:Comprehensive Rules with the new Template:CR.
• Check UserWiki:RuleUpdateBot for any further pages that need to be converted.

Template:CR converted

All old uses of Template:CR have been replaced. That page now implements this module, and Template:CRTemp redirects to Template:CR. -Corveroth (talk) 23:40, 5 August 2015 (UTC)

Bug Reports

• lookup=Effects returns the heading "6. Spells, Abilities, and Effects" rather than rule 609, "Effects". Affected page: Effects
• lookup=Prevention Effects extends to the next heading (same bug as above). Affected page: Prevention Effect
• Examples are formatted with a double bullet. This shows on mobile in particular. What's happening is that the rule before it is in a <ul> element, which is closed before the example begins, then two new (nested) ones start with only the example in them. The example should be in the same <ul> as the rule just before it.
• Formatting on mobile is less than ideal in general. Bullets that should be hidden are shown and the bounding box is too small; see for example Commander (format) under "Play Rules". Thrawcheld (talk) 12:46, 12 August 2015 (UTC)
  • Both of these bugs are really effects of the mobile stylesheet for this wiki, which is terrible. I'm not sure how much of this is within my capacity to fix, but I'll look into it. -Corveroth (talk) 17:38, 12 August 2015 (UTC)

To-do list (coding changes to the module)

• Allow title-based lookups to be case independent. At the moment, lookup=Creatures works, but lookup=creatures does not.
• Build a list of common names for rules that are not titled as such in the CR, but which would be accepted by the module.
  • For example, the module might allow {{CR|lookup=Legend Rule}}, despite no title in the CR named "Legend Rule", and use an internal list of such faux-titles to equate that lookup with the correct index (in this case, at the moment, 704.5k).
• Look into a means of allowing lookups for the General titles without using indices. The TOC output appends the title of the section, but this doesn't currently work on input.

Visual Styling

Feel free to use this heading to contribute and debate any suggestions or requests for alterations to the visual style of output from the module. Corveroth (talk) 05:00, 5 August 2015 (UTC)

Requests

• Your ad here

Under Consideration

• Re-implement the leading bullet point on the zeroth level of indentation (i.e. on the first line). It looks a little odd like this, even if the bullet point is unnecessary.
• Linking key phrases within the transcluded text - key words like "trample" and rules titles like "end step".
• Replacing {W}, {1}, {S}, etc with their symbols
  • Why: Looks pretty.
  • Why not: The official CR documents use the text representations of those symbols. I want both an honest quote and to reinforce that those representations are canonical.
• Adding a way to specify multiple rules that are printed in the same rulebox for use-cases like Untap#Untap_symbol --Hanmac (talk) 15:23, 5 August 2015 (UTC)
  • Why should two separate rules occupy the same box, rather than be separate quotes? Is it simply due to the space taken by the extra title, padding, margin? Corveroth (talk) 18:42, 5 August 2015 (UTC)

To-Do List

• Your ad here

Not Happening

• No suggestions have yet been rejected by consensus

Prepare for Launch

I think the module is good enough that further work on the code is largely stalling on my part. Here are my goals for the implementation of the module:

• Affect all pages currently using Template:Rules, Template:Comprehensive Rules, Template:CR, and those explicitly listed on UserWiki:RuleUpdateBot.
• Avoid directly using Module:CR in the article namespace.
• Implement invocation of Module:CR within Template:CR.

• Later editors should be able to utilize the template without worrying about changes to the underlying module or how the template generates the correct wikitext.

• Retire Template:Rules and Template:Comprehensive Rules entirely, either via deletion or redirect to Template:CR (currently, CR redirects to Comprehensive Rules).
• Accomplish all of this transparently from the visitor's perspective - no broken pages at any point during the process.

I'll be sleeping on it and get started tomorrow morning. Corveroth (talk) 04:25, 24 July 2015 (UTC)

Good luck! I'll lend a hand where needed. --Hunter (talk) 05:56, 24 July 2015 (UTC)

Update: Pages currently using Template:CR will be rewritten to use Template:CRTemp so as not to break them when the former template is updated. Afterwards, the new template will redirect back to the updated version of CR, and any pages using CRTemp can optionally be converted to use CR directly at leisure. Pages using Template:CR are top priority for conversion so as to open up that template for editing. Other templates can wait. For now though, I'm off to FNM to play some janky Standard Izzet ETB thing. Corveroth (talk) 00:42, 25 July 2015 (UTC)

First 50 down, 200+ Template:CR uses to go! One small issue I noticed along the way is that the module is dropping the examples that should be in the transcluded text. That's easy enough to address in a later update. Corveroth (talk) 08:09, 25 July 2015 (UTC)

Another hiccup. This doesn't show the complete text (apart from the example) The sentence about the evasion ability is missing --Hunter (talk) 18:20, 4 August 2015 (UTC)

From the Comprehensive Rules (June 7, 2024—Modern Horizons 3)

• 509.1b The defending player checks each creature they control to see whether it’s affected by any restrictions (effects that say a creature can’t block, or that it can’t block unless some condition is met). If any restrictions are being disobeyed, the declaration of blockers is illegal.
  A restriction may be created by an evasion ability (a static ability an attacking creature has that restricts what can block it). If an attacking creature gains or loses an evasion ability after a legal block has been declared, it doesn’t affect that block. Different evasion abilities are cumulative.

  Example: An attacking creature with flying and shadow can’t be blocked by a creature with flying but without shadow.

Think I've got both those issues nailed, plus I nixed the superfluous bullet before 0th-level indentation. Should propagate shortly! (and, for what it's worth, examples are indented at a fixed indent, independent of their depth in the rules. In terms of layout, they match the style used in the PDF version of the CR) Corveroth (talk) 02:35, 5 August 2015 (UTC)

Continuing in this thread - that's a batch of another ~100 articles converted. About 150 left to go! Corveroth (talk) 06:06, 5 August 2015 (UTC)

Keyword action linking to a disambig page

An instance of this template on Keyword action#rules contains a link to Counter (a disambiguation page) which should point at Counter (keyword action) instead. —Fenhl 23:11, 6 October 2015 (UTC)

Glossary

How lookup the Glossary entries? - Yandere Sliver 23:54, 28 December 2015 (UTC)

I never actually implemented such. If you're capable, feel free to clone this module to a separate test page and try out your own implementation, then merge back once it works. Otherwise, I'll get to it when I have the chance. --Corveroth (talk) 00:40, 29 December 2015 (UTC)

This is now implemented. See Test. --Corveroth (talk) 23:28, 6 January 2016 (UTC)

Thank you. That was quick. That means we can update some articles especially the obsolete terms. :) - Yandere Sliver 00:06, 7 January 2016 (UTC)