Module talk:CR: Difference between revisions

From MTG Wiki
Jump to navigation Jump to search
>Corveroth
No edit summary
>Corveroth
No edit summary
Line 1: Line 1:
'''Please use the module indirectly via [[Template:CRTemp]], or [[Template:CR]] if the latter has been converted (see below).'''
'''Please use the module indirectly via [[Template:CR]].'''
Using the module directly is more likely to break in the future.


Using the module directly is more likely to break in the future.


= Work to be done (Article editing) =
= Work to be done (Article editing) =
The first two bullet points need to be completed in order. Afterwords, work can continue in any order.
* Replace uses of [[Template:CR]] with [[Template:CRTemp]].
* When the above step is done, copy the contents of [[Template:CRTemp]] to [[Template:CR]], and then leave a redirect on CRTemp.
* Replace uses of [[Template:Rules]] and [[Template:Comprehensive Rules]] with the new [[Template:CR]].
* Replace uses of [[Template:Rules]] and [[Template:Comprehensive Rules]] with the new [[Template:CR]].
* Check [[UserWiki:RuleUpdateBot]] for any further pages that need to be converted.
* Check [[UserWiki:RuleUpdateBot]] for any further pages that need to be converted.
=== Template:CR converted ===
All old uses of [[Template:CR]] have been replaced. That page now implements this module, and [[Template:CRTemp]] redirects to [[Template:CR]]. -[[User:Corveroth|Corveroth]] ([[User talk:Corveroth|talk]]) 23:40, 5 August 2015 (UTC)





Revision as of 23:40, 5 August 2015

Please use the module indirectly via Template:CR. Using the module directly is more likely to break in the future.


Work to be done (Article editing)

Template:CR converted

All old uses of Template:CR have been replaced. That page now implements this module, and Template:CRTemp redirects to Template:CR. -Corveroth (talk) 23:40, 5 August 2015 (UTC)


Bug Reports

  • lookup=Effects returns the heading "6. Spells, Abilities, and Effects" rather than rule 609, "Effects". Affected page: Effects
  • lookup=Prevention Effects extends to the next heading (same bug as above). Affected page: Prevention Effect


To-do list (coding changes to the module)

  • Allow title-based lookups to be case independent. At the moment, lookup=Creatures works, but lookup=creatures does not.
  • Create glossary lookups for terminology not in the rules. This would utilize the glossary provided at the bottom of the CR.
    • For example, "interrupt", and possibly ability words.
  • Build a list of common names for rules that are not titled as such in the CR, but which would be accepted by the module.
    • For example, the module might allow {{CR|lookup=Legend Rule}}, despite no title in the CR named "Legend Rule", and use an internal list of such faux-titles to equate that lookup with the correct index (in this case, at the moment, 704.5k).
  • Look into a means of allowing lookups for the General titles without using indices. The TOC output appends the title of the section, but this doesn't currently work on input.


Visual Styling

Feel free to use this heading to contribute and debate any suggestions or requests for alterations to the visual style of output from the module. Corveroth (talk) 05:00, 5 August 2015 (UTC)

Requests

  • Your ad here

Under Consideration

  • Re-implement the leading bullet point on the zeroth level of indentation (i.e. on the first line). It looks a little odd like this, even if the bullet point is unnecessary.
  • Linking key phrases within the transcluded text - key words like "trample" and rules titles like "end step".
  • Replacing {W}, {1}, {S}, etc with their symbols
    • Why: Looks pretty.
    • Why not: The official CR documents use the text representations of those symbols. I want both an honest quote and to reinforce that those representations are canonical.
  • Adding a way to specify multiple rules that are printed in the same rulebox for use-cases like Untap#Untap_symbol --Hanmac (talk) 15:23, 5 August 2015 (UTC)
    • Why should two separate rules occupy the same box, rather than be separate quotes? Is it simply due to the space taken by the extra title, padding, margin? Corveroth (talk) 18:42, 5 August 2015 (UTC)

To-Do List

  • Your ad here

Not Happening

  • No suggestions have yet been rejected by consensus


Prepare for Launch

I think the module is good enough that further work on the code is largely stalling on my part. Here are my goals for the implementation of the module:

  • Later editors should be able to utilize the template without worrying about changes to the underlying module or how the template generates the correct wikitext.
  • Retire Template:Rules and Template:Comprehensive Rules entirely, either via deletion or redirect to Template:CR (currently, CR redirects to Comprehensive Rules).
  • Accomplish all of this transparently from the visitor's perspective - no broken pages at any point during the process.

I'll be sleeping on it and get started tomorrow morning. Corveroth (talk) 04:25, 24 July 2015 (UTC)

Good luck! I'll lend a hand where needed. --Hunter (talk) 05:56, 24 July 2015 (UTC)
Update: Pages currently using Template:CR will be rewritten to use Template:CRTemp so as not to break them when the former template is updated. Afterwards, the new template will redirect back to the updated version of CR, and any pages using CRTemp can optionally be converted to use CR directly at leisure. Pages using Template:CR are top priority for conversion so as to open up that template for editing. Other templates can wait. For now though, I'm off to FNM to play some janky Standard Izzet ETB thing. Corveroth (talk) 00:42, 25 July 2015 (UTC)
First 50 down, 200+ Template:CR uses to go! One small issue I noticed along the way is that the module is dropping the examples that should be in the transcluded text. That's easy enough to address in a later update. Corveroth (talk) 08:09, 25 July 2015 (UTC)
Another hiccup. This doesn't show the complete text (apart from the example) The sentence about the evasion ability is missing --Hunter (talk) 18:20, 4 August 2015 (UTC)

From the Comprehensive Rules (June 7, 2024—Modern Horizons 3)

  • 509.1b The defending player checks each creature they control to see whether it’s affected by any restrictions (effects that say a creature can’t block, or that it can’t block unless some condition is met). If any restrictions are being disobeyed, the declaration of blockers is illegal.
    A restriction may be created by an evasion ability (a static ability an attacking creature has that restricts what can block it). If an attacking creature gains or loses an evasion ability after a legal block has been declared, it doesn’t affect that block. Different evasion abilities are cumulative.

    Example: An attacking creature with flying and shadow can’t be blocked by a creature with flying but without shadow.

Think I've got both those issues nailed, plus I nixed the superfluous bullet before 0th-level indentation. Should propagate shortly! (and, for what it's worth, examples are indented at a fixed indent, independent of their depth in the rules. In terms of layout, they match the style used in the PDF version of the CR) Corveroth (talk) 02:35, 5 August 2015 (UTC)
Continuing in this thread - that's a batch of another ~100 articles converted. About 150 left to go! Corveroth (talk) 06:06, 5 August 2015 (UTC)